Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(profiling): Refactor profile processing into its own crate #1340

Merged
merged 13 commits into from
Jul 22, 2022
Merged

ref(profiling): Refactor profile processing into its own crate #1340

merged 13 commits into from
Jul 22, 2022

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Jul 13, 2022

As we're putting more and more code into it, @jan-auer requested we separate our code into its own crate.

@phacops phacops requested a review from a team July 13, 2022 21:02
@phacops phacops requested review from jjbayer and jan-auer July 20, 2022 20:01
@phacops phacops enabled auto-merge (squash) July 22, 2022 14:03
@phacops phacops disabled auto-merge July 22, 2022 14:45
jan-auer
jan-auer approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments below.

Thanks for the refactor, this indeed makes the code very readable and adds clear separation.

CHANGELOG.md Outdated Show resolved Hide resolved
relay-profiling/src/android.rs Outdated Show resolved Hide resolved
relay-profiling/Cargo.toml Outdated Show resolved Hide resolved
@phacops phacops enabled auto-merge (squash) July 22, 2022 17:10
@phacops phacops merged commit 62d4172 into master Jul 22, 2022
@phacops phacops deleted the pierre/profiling-refactor-into-crate branch July 22, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phacops @jan-auer @jjbayer