fix(metrics): Fix broken extraction of ops breakdown and conditional tagging [INGEST-1529] #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tagging Since we moved metrics extraction to PoP relays, we screwed up ops breakdown and satisfaction and outlier tagging.
jan-auer
approved these changes
Jul 28, 2022
untitaker
deleted the
fix/metrics-extraction-missing-breakdowns-and-tagging
branch
jan-auer
added a commit
that referenced
this pull request
Jul 28, 2022
* master: fix(metrics): Fix broken extraction of ops breakdown and conditional tagging (#1357) fix(unreal): Don't drop event in PoP relays [INC-181] [ISSUE-1558] (#1355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving metric extraction out of processing mode, we missed adding the required project config fields to the
LimitedProjectConfigstructure that is sent to untrusted Relays. This caused invalid tagging for ops breakdowns and histograms.Ref #1344
#skip-changelog