fix(metrics): Extract user from metrics correctly [INGEST-1521] #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Jul 29, 2022
jjbayer
reviewed
Jul 29, 2022
| /// here: https://github.com/getsentry/sentry/blob/f621cd76da3a39836f34802ba9b35133bdfbe38b/src/sentry/event_manager.py#L790-L794 | ||
| /// | ||
| /// `sentry.models.eventuser.KEYWORD_MAP` determines which attributes are looked up in which order. | ||
| /// If its order is changed, this function needs to be changed. |
jjbayer
approved these changes
Jul 29, 2022
iker-barriocanal
approved these changes
Aug 1, 2022
Comment on lines
570
to
571
| /// `sentry.models.eventuser.KEYWORD_MAP` determines which attributes are looked up in which order. | ||
| /// If its order is changed, this function needs to be changed. |
There was a problem hiding this comment.
Does it make sense to, at some point, extract this order into the config? I think it's easier to change the config over changing the code.
There was a problem hiding this comment.
I don't think we can ever change this order without breaking a ton of users to be honest.
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the way we determine user counts in metrics is not similar to how we do it in events. See code comments for how it's done now.