fix(profiling): The priority thread metadata is optional #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The priority in the thread metadata is now an optional value. This is causing failures in validation and rejected profiles.
indragiek
approved these changes
Aug 8, 2022
jan-auer
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Note that clients sending this to old Sentry instances will still cause failures. If you'd like to prevent this, consider marking more fields as optional that aren't absolutely needed for your processing.
I'm approving this to unblock, but please do not deploy this change until #1394 has been merged.
untitaker
approved these changes
Aug 9, 2022
Zylphrex
deleted the
txiao/fix/profiling-priority-thread-metadata-is-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The priority in the thread metadata is now an optional value. This is causing
failures in validation and rejected profiles.