ref(server): Add a message to capture envelopes in capture mode #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
force-pushed
the
ref/capture-message
branch
from
6647fd7 to
ee3ace2
Compare
jjbayer
approved these changes
Aug 11, 2022
| @@ -369,6 +369,10 @@ where | |||
| metric!(counter(RelayCounters::EnvelopeRejected) += 1); | |||
| let event_id = *event_id.borrow(); | |||
|
|
|||
| if Capture::should_capture(&config) { | |||
| EnvelopeManager::from_registry().do_send(Capture::rejected(event_id, &error)); | |||
| } | |||
There was a problem hiding this comment.
Was this case previously uncaptured? Or did it happen somewhere else?
There was a problem hiding this comment.
This was previously not captured, correct. The fast path also bypassed other means of the envelope manager, such as the buffer capacity check.
| } | ||
|
|
||
| if Capture::should_capture(&self.config) { | ||
| context.notify(Capture::accepted(envelope)); |
There was a problem hiding this comment.
Is it better to .notify, or to call .handle() directly?
There was a problem hiding this comment.
Good question, I went with notify just because that's how actix documents sending messages to the own actor. Probably calling handle would be more direct or even efficient. The immediate next PR is going to move this to another actor anyway, so calling notify here is closer to target behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay has a capture mode used for testing. In this mode it does not send envelopes to Kafka or the upstream, but rather keeps them in an internal map. There is a hidden endpoint with which a tester can extract the captured envelopes and inspect them for errors.
Until now, envelopes were all handled and captured by the envelope manager. The final goal is to remove the long-running handler future in
EnvelopeManager, which requires to capture rejections from other places than the envelope manager.This change introduces a message to capture envelopes or rejections from any place in the code base. In subsequent refactors, individual error handlers can send their errors into capture mode using this message.
Follow-Ups
Follow-ups continued from #1406 and #1408:
#skip-changelog