Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): Generate a new profile ID when splitting a profile for multiple transactions #1473

Merged
merged 4 commits into from
Sep 19, 2022
Merged

fix(profiling): Generate a new profile ID when splitting a profile for multiple transactions #1473

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0be05f9
fix(profiling): Generate a new profile ID when splitting for multiple…
phacops Sep 14, 2022
f1c8ff7
Add PR to change log entry
phacops Sep 14, 2022
979bd69
Merge branch 'master' into pierre/profiling-generate-new-profile-id
phacops Sep 19, 2022
3fab1b6
Fix changelog
phacops Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions relay-profiling/src/android.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ pub fn expand_android_profile(payload: &[u8]) -> Result<Vec<Vec<u8>>, ProfileErr
for transaction in &profile.transactions {
let mut new_profile = profile.clone();

new_profile.profile_id = EventId::new();
new_profile.set_transaction(transaction);
new_profile.transactions.clear();

Expand Down
1 change: 1 addition & 0 deletions relay-profiling/src/cocoa.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ pub fn expand_cocoa_profile(payload: &[u8]) -> Result<Vec<Vec<u8>>, ProfileError
for transaction in &profile.transactions {
let mut new_profile = profile.clone();

new_profile.profile_id = EventId::new();
new_profile.set_transaction(transaction);
new_profile.transactions.clear();

Expand Down