feat(quotas): Always require transaction processing quota #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainly this adds a new field in enforcement. i may try a vec next INGEST-1354 INGEST-1587
This is an approach that generically allows multiple data categories for events. The resulting code is fairly reasonable.
The envelope limiter needs to avoid calling redis again and needs to remove items that need to be removed. This does that but it is not hooked up properly as the rate_limited_categories which are passed through the processing are too simplistic and instead I want to pass the enforcement through. That still needs to be hooked up.
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
We must have processing quota in order to index a transaction.
Instructions and example for changelogFor changes exposed to the Python package, please add an entry to For changes to the Relay server, please add an entry to
To the changelog entry, please add a link to this PR (consider a more descriptive message): - always require processing quota. ([#1507](https://github.com/getsentry/relay/pull/1507))If none of the above apply, you can opt out by adding #skip-changelog to the PR description. |
added 3 commits
September 30, 2022 14:26
This does things like clock drift correction that might still be needed, it is lightweight anyway.
added 2 commits
October 4, 2022 10:39
jan-auer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.