fix(quotas): Make redis rate limiter work with quantity 0 [INGEST-1656] #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2022
jan-auer
reviewed
Oct 7, 2022
| @@ -57,8 +63,10 @@ if not failed then | |||
| local k = i * 2 + 1 | |||
| local v = i * 3 + 1 | |||
|
|
|||
| redis.call('INCRBY', KEYS[k], ARGV[v + 2]) | |||
| redis.call('EXPIREAT', KEYS[k], ARGV[v + 1]) | |||
| if tonumber(ARGV[v + 2]) > 0 then | |||
There was a problem hiding this comment.
Consider this an optimization. I'm assuming that the check is quite a bit faster than executing the two commands below.
flub
approved these changes
Oct 7, 2022
* master: ref: Remove unused rate_limits from ProcessEnvelopeState (#1516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1515, it is required to check for a required quota of another data category without incrementing it. This PR updates the Redis LUA script to support a rate limiting quantity of
0, which checks for existing rate limits without incrementing internal counters.The rate limiter gains a new explicit branch to check whether the quantity is
0. We could have indirectly achieved the same effect withmax(quantity, 1).