Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(kafka): Move code into separate crate [INGEST-1627] #1563

Merged
merged 16 commits into from
Nov 15, 2022
Merged

ref(kafka): Move code into separate crate [INGEST-1627] #1563

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ab5b660
ref(kafka): Move functionality into separate crate.
olksdr Sep 19, 2022
ef55250
Add CHANGELOG record
olksdr Nov 3, 2022
3050fca
Merge branch 'master' into feat/relay-kafka-crate
olksdr Nov 3, 2022
f2422ca
Merge branch 'master' into feat/relay-kafka-crate
olksdr Nov 3, 2022
845a5ef
set ci timouts for tests on 20 min
olksdr Nov 4, 2022
881c9b7
Merge branch 'master' into feat/relay-kafka-crate
olksdr Nov 7, 2022
0d97340
ref(kafka): Address the review comments: docs, debug, mods, features
olksdr Nov 7, 2022
ead25b2
ref(kafka): Create statsd module
olksdr Nov 9, 2022
228bd89
Merge branch 'master' into feat/relay-kafka-crate
olksdr Nov 9, 2022
c549186
ref(kafka): Simplify kafka client/producer API
olksdr Nov 14, 2022
3e932ac
Merge branch 'master' into feat/relay-kafka-crate
olksdr Nov 14, 2022
ca5aeac
fix lint
olksdr Nov 14, 2022
1016670
fix lint for default features
olksdr Nov 14, 2022
53d67b4
ref(kafka): make sure all existing test cases pass
olksdr Nov 14, 2022
45fa6e5
doc compile fail
olksdr Nov 14, 2022
19548cd
ref(kafka): Address final review comments
olksdr Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
args: --workspace --all-targets --no-deps -- -D warnings

test:
timeout-minutes: 15
timeout-minutes: 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that timeout change still required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be removed now. Added before rust cache fix.

strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
args: --workspace

test_all:
timeout-minutes: 15
timeout-minutes: 20
name: Test All Features (ubuntu-latest)
runs-on: ubuntu-latest

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: run
args: -p document-metrics -- -o relay_metrics.json relay-server/src/statsd.rs relay-metrics/src/statsd.rs
args: -p document-metrics -- -o relay_metrics.json relay-server/src/statsd.rs relay-metrics/src/statsd.rs relay-kafka/src/statsd.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is easy to miss when adding a crate, would a glob pattern work here? That is, relay-*/src/statsd.rs


- name: Deploy
if: github.ref == 'refs/heads/master'
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Support dedicated quotas for storing transaction payloads ("indexed transactions") via the `transaction_indexed` data category if metrics extraction is enabled. ([#1537](https://github.com/getsentry/relay/pull/1537), [#1555](https://github.com/getsentry/relay/pull/1555))
- Report outcomes for dynamic sampling with the correct indexed transaction data category to restore correct totals. ([#1561](https://github.com/getsentry/relay/pull/1561))
- Add fields to the Frame object for the sample format. ([#1562](https://github.com/getsentry/relay/pull/1562))
- Move kafka related code into separate `relay-kafka` crate. ([#1563](https://github.com/getsentry/relay/pull/1563))

## 22.10.0

Expand Down
19 changes: 17 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions relay-config/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ human-size = "0.4.1"
num_cpus = "1.13.0"
relay-auth = { path = "../relay-auth" }
relay-common = { path = "../relay-common" }
relay-kafka = { path = "../relay-kafka" }
relay-log = { path = "../relay-log", features = ["init"] }
relay-metrics = { path = "../relay-metrics" }
relay-redis = { path = "../relay-redis" }
Expand Down
Loading