feat(profiling): Expand the discard reasons #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
reviewed
Dec 2, 2022
jjbayer
approved these changes
Dec 2, 2022
phacops
force-pushed
the
pierre/profiling-expand-discard-reasons
branch
2 times, most recently
from
bed1e58 to
c9bd032
Compare
phacops
force-pushed
the
pierre/profiling-expand-discard-reasons
branch
from
c9bd032 to
f849cbc
Compare
Zylphrex
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only have a limited number of discard reasons for profiling and as the number of invalid profiles grow, it's difficult to understand why and make sure it's not due to a bug.
This PR aims to add more discard reasons and log an error in case we have a JSON deserialization error so we can investigate and fix it.