feat(replays): Filter recordings which could not be parsed #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iker-barriocanal
approved these changes
Dec 12, 2022
|
Is this PR still relevant? |
|
@iker-barriocanal Still relevant. If PII scrubbing fails we'll want to reject. I'll update this pull as we get closer to that point. |
jan-auer
force-pushed
the
replays-discard-unparsable-replays
branch
from
232e0ee to
97de43f
Compare
jjbayer
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop replay recording payloads if they fail processing, which happens either when they contain invalid JSON or when data scrubbing fails. If replay processing is disabled, Relay does not inspect the payloads and unconditionally retains them.
Closes https://github.com/getsentry/replay-backend/issues/229