Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(normalize): Keep meta for removed custom measurements #1815

Merged
merged 3 commits into from
Feb 3, 2023
Merged

feat(normalize): Keep meta for removed custom measurements #1815

merged 3 commits into from
Feb 3, 2023

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Feb 3, 2023

This adds a _meta entry for custom measurements that have been removed during
normalization as a result of the custom measurements limit. The entry contains
a generic error message along with the payloads of all removed measurements.

See #1712

@jan-auer jan-auer requested a review from a team February 3, 2023 11:13
@jan-auer jan-auer mentioned this pull request Feb 3, 2023
Closed
@jan-auer jan-auer self-assigned this Feb 3, 2023
@jan-auer jan-auer enabled auto-merge (squash) February 3, 2023 11:29
olksdr
olksdr approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jan-auer jan-auer merged commit da6fda6 into master Feb 3, 2023
@jan-auer jan-auer deleted the feat/normalize-measurements-limit-meta branch February 3, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olksdr olksdr olksdr approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @olksdr