Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(profiling): Add donet support for profiling #1885

Merged
merged 2 commits into from
Feb 27, 2023
Merged

feat(profiling): Add donet support for profiling #1885

merged 2 commits into from
Feb 27, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Feb 24, 2023

No description provided.

@phacops phacops requested a review from a team as a code owner February 24, 2023 22:42
@phacops phacops requested a review from a team February 24, 2023 22:43
@phacops phacops mentioned this pull request Feb 24, 2023
Closed
@jan-auer
Copy link
Member

Would it make sense to treat everything else as a generic platform instead of listing all of them explicitly?

@phacops
Copy link
Contributor Author

phacops commented Feb 27, 2023

Absolutely. I think we'd have done that already if we anticipated 3 new platforms, so our bad. We'll make the change before the next wave.

@phacops phacops enabled auto-merge (squash) February 27, 2023 18:26
@phacops phacops merged commit 1a6cdf9 into master Feb 27, 2023
@phacops phacops deleted the pierre/profiling-dotnet-javascript-platforms branch February 27, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zylphrex Zylphrex Zylphrex approved these changes

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phacops @jan-auer @Zylphrex