Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ref(cache): Move buffering of pending envelope to ProjectCache" #1906

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Revert "ref(cache): Move buffering of pending envelope to ProjectCache" #1906

merged 2 commits into from
Mar 6, 2023

Conversation

olksdr
Copy link
Contributor

@olksdr olksdr commented Mar 6, 2023 •
edited
Loading

Reverts #1879

Introduced regression: RELAY-2NFR

The project key on the ProjectState in only few cases was missing, when the majority of messages went through ok.

#skip-changelog

@olksdr olksdr requested a review from a team March 6, 2023 15:12
jjbayer
jjbayer approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the description with the reason why we're reverting (e.g. link to sentry issue).

Note there's also the Trigger: revert label to automatically revert and skip CI.

@olksdr olksdr enabled auto-merge (squash) March 6, 2023 15:27
@olksdr olksdr merged commit d016d0f into master Mar 6, 2023
@olksdr olksdr deleted the revert-1879-feat/project-cache-queue branch March 6, 2023 15:45
@olksdr olksdr mentioned this pull request Mar 7, 2023
Merged
olksdr added a commit that referenced this pull request Mar 7, 2023
@olksdr
Revert "Revert "ref(cache): Move buffering of pending envelope to Pro…
c4eaff5 
…jectCache" (#1906)"

This reverts commit d016d0f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olksdr @jjbayer