Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Spray-and-pray hotfixes to avoid exploding event sizes in store #191

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

untitaker
Copy link
Member

ref getsentry/sentry#12375

We are running into the problem that running parts of the store normalizer on the same payload will bloat events to ridiculous sizes. Make sure that:

  • We don't store the same error twice
  • We don't store too large original_value

@untitaker
Copy link
Member Author

For the curious third-party spectator, here are some fun metrics we recorded in datadog:

Screenshot 2019-04-03 at 21 26 06

When the blue line goes up, we turned on rust renormalization.

The purple line is the largest event size recorded at that time interval. Subject to datadog's sampling/magic/bugginess. We have larger events for sure. Anyway, there's a spike that shouldn't be there.

@untitaker untitaker merged commit 8dcbab8 into master Apr 3, 2019
@untitaker untitaker deleted the fix/size-explosion-hotfixes branch April 3, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants