fix(pii): Scrub sensitive cookies #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
added a commit
that referenced
this pull request
Mar 21, 2023
If a list of chunks consists only of replacements, the following debug assertion at the end of `apply_replacement_chunks` might fail (see test): https://github.com/getsentry/relay/blob/a8ee53cc26b8d7bd10cfa919e672894edbd65916/relay-general/src/pii/processor.rs#L346 Add an early return to prevent this failure. This popped up in a test case in #1951.
mdtro
force-pushed
the
fix/scrub-session
branch
from
cfe9e6c to
790d522
Compare
iker-barriocanal
approved these changes
Mar 22, 2023
jjbayer
commented
Mar 22, 2023
…nflict with other scrubbers
mdtro
force-pushed
the
fix/scrub-session
branch
from
44ed9ea to
83f2870
Compare
jan-auer
added a commit
that referenced
this pull request
Mar 24, 2023
* master: feat(normalization): Mark scrubbed transactions as sanitized (#1960) fix(pii): Scrub sensitive cookies (#1951) release: 23.3.1 feat(pii-scrubbing): PII scrub span.data by default (#1953) test(scrubbing): Add tests for PII scrubbing in breadcrumb.data (#1955) build(deps): bump sentry-sdk from 1.11.0 to 1.14.0 (#1959) ref(envelope_manager): Remove from_registry calls from the service (#1956) cd: add placeholder deployment pipeline (#1954) Assert array fields are capped to 100 items (#1910) fix(pii): Early return if no text left (#1957)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always scrub cookies that are known to be session cookies.
Fixes #1706