Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol) Add new mechanism fields to protocol to support exception groups #2020

Merged
merged 6 commits into from
Apr 12, 2023
Merged

feat(protocol) Add new mechanism fields to protocol to support exception groups #2020

merged 6 commits into from
Apr 12, 2023

Conversation

mattjohnsonpint
Copy link
Contributor

Adds 4 new fields to the mechanism protocol to support exception groups, per Sentry RFC 79

@mattjohnsonpint mattjohnsonpint requested review from a team and jjbayer April 7, 2023 19:26
olksdr
olksdr approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

relay-general/src/protocol/mechanism.rs Outdated Show resolved Hide resolved
iker-barriocanal
iker-barriocanal approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing and putting the effort to write these amazing docs! Approving to not keeping you blocked, but please address the comment about limiting the character set in the string.

relay-general/tests/snapshots/test_fixtures__event_schema.snap Show resolved Hide resolved
relay-general/src/protocol/mechanism.rs Outdated Show resolved Hide resolved
relay-general/src/protocol/mechanism.rs Show resolved Hide resolved
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) April 12, 2023 16:00
@mattjohnsonpint mattjohnsonpint merged commit 3064016 into master Apr 12, 2023
@mattjohnsonpint mattjohnsonpint deleted the feat/mechanism-schema branch April 12, 2023 16:37
@mattjohnsonpint mattjohnsonpint mentioned this pull request Apr 14, 2023
Merged
@malwilley malwilley mentioned this pull request Apr 19, 2023
Merged
malwilley added a commit to getsentry/sentry that referenced this pull request Apr 19, 2023
@malwilley
feat(exception-group): Add new mechanism fields to Exception interface (
f444d8a 
#47643)

Mirrors the properties added in
getsentry/relay#2020

Without this change the event endpoints will strip these values.
@mattjohnsonpint mattjohnsonpint mentioned this pull request May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

@olksdr olksdr olksdr approved these changes

@jjbayer jjbayer Awaiting requested review from jjbayer

@jan-auer jan-auer Awaiting requested review from jan-auer

Assignees

@mattjohnsonpint mattjohnsonpint

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattjohnsonpint @olksdr @iker-barriocanal