Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Support access to structured release fields #2276

Merged
merged 4 commits into from
Jul 3, 2023

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jul 3, 2023

Add support for virtual version fields to FieldValueProvider, which makes them
accessible to dynamic sampling and generic metrics extraction.

SemVer comparisons are not yet possible on the release version.

@jan-auer jan-auer self-assigned this Jul 3, 2023
relay-general/src/protocol/event.rs Outdated Show resolved Hide resolved
relay-general/src/protocol/event.rs Outdated Show resolved Hide resolved
@jan-auer
Copy link
Member Author

jan-auer commented Jul 3, 2023

I will actually put a bit more work into this right away and make sure that we parse the correct build hash always.

@jan-auer jan-auer enabled auto-merge (squash) July 3, 2023 16:01
@jan-auer jan-auer merged commit 0a6b6b3 into master Jul 3, 2023
@jan-auer jan-auer deleted the feat/release-fields branch July 3, 2023 16:14
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants