feat(metrics): Route to different aggregators #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Jul 24, 2023
| .map(|mri| mri.namespace) | ||
| .ok() | ||
| }); | ||
| // TODO: Parse MRI only once, move validation from Aggregator here. |
There was a problem hiding this comment.
Will take care of this in a follow-up.
TBS1996
reviewed
Jul 24, 2023
TBS1996
reviewed
Jul 24, 2023
| } | ||
| }); | ||
| }); | ||
| relay_statsd::metric!( |
There was a problem hiding this comment.
really wish github would show it in another color if only the indentation changed
TBS1996
reviewed
Jul 24, 2023
| Aggregator::InsertMetrics(msg) => self.handle_metrics(msg), | ||
| Aggregator::MergeBuckets(msg) => self.handle_metrics(msg), | ||
| #[cfg(test)] | ||
| Aggregator::BucketCountInquiry(_, _sender) => (), // not supported |
There was a problem hiding this comment.
I suppose this is fine because the tests will simply use the aggregator service directly?
There was a problem hiding this comment.
Yeah it's not ideal, but acceptable IMO because this message is only used in one test.
TBS1996
approved these changes
Jul 24, 2023
Co-authored-by: Tor <tor.saebjoernsen@sentry.io>
jjbayer
added a commit
that referenced
this pull request
Jul 25, 2023
We currently shift the flush time of each metrics bucket by an offset based on the project key. This prevents large peaks every interval, but still allows flushing buckets from the same projects together, which makes sense especially when the buckets are then sent to the upstream in per-project envelopes. With span metrics, we have seen that even buckets from the same project can cause a lot of traffic. With #2341, we want to increase the bucket interval for span metrics to one minute. To prevent large, project-specific peaks for span metrics, allow configuring a more random distribution over time. This should be used only in processing Relays where buckets are sent via Kafka.
jjbayer
added a commit
that referenced
this pull request
Jul 26, 2023
Follow-up to #2341: Now that span metrics can have their own configuration, use the correct one to trim span descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place a router in front of the
relay_metrics::Aggregatorservice, to allow different aggregator configurations for different use cases. This will allow us toOld:
flowchart LR Service -->|metrics| AggregatorNew: