feat: add cross-origin-resource-policy response header #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
requested changes
Aug 9, 2023
@olksdr Thank you for the suggestion. I wasn't too sure where to add them, but I was able to track down where the other CORS headers are tested as well. Please let me know if the added test is sufficient. :) |
olksdr
approved these changes
Aug 10, 2023
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
mdtro
force-pushed
the
mdtro/feat/corp-response-header
branch
from
a5bf519 to
0d6d9e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for getsentry/sentry#41225.
Browsers are starting to require the CORP header it seems. Relay sets
Access-Control-Allow-Origin: *, but this is not sufficient for those that have stricter headers set:tower_http's CORS module does not support CORP/COOP/COEP so I just added the static header on the response.