hackweek: Relay dashboard #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a454bc6.
…o feat/admin-dashboard
olksdr
approved these changes
Sep 6, 2023
| if let Ok(Ok(bytes)) = spawn_blocking(move || rx.recv()).await { | ||
| let message = String::from_utf8_lossy(&bytes).to_string(); | ||
| let res = socket.send(message.into()).await; | ||
| if res.is_err() { |
There was a problem hiding this comment.
The error happens only on client disconnect or is there a specific error we should be looking for?
There was a problem hiding this comment.
I copied this straight from the example so it Should Be Fine™.
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
iker-barriocanal
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Web UI Dashboard to Relay.
TODOs
Bugs
How this looks like now
Currently we can see:
statsdmetrics - the graphs will appear as soon as there are any data produced