Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Enable spans needed for the mobile Starfish module #2570

Merged
merged 8 commits into from
Oct 5, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Oct 5, 2023

  • app.* span descriptions are low cardinality.
  • ui.load* are also scrubbed but not high cardinality (it's a function of the number of methods in an application).
  • file.* are scrubbed to just get the extension.

@phacops phacops requested review from jjbayer and a team October 5, 2023 14:34
@phacops phacops merged commit 5517346 into master Oct 5, 2023
@phacops phacops deleted the pierre/spans-enable-mobile-module-spans branch October 5, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants