Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spans): Scrub resource span description even when we don't detect an extension #2591

Merged
merged 16 commits into from
Oct 12, 2023
Merged

fix(spans): Scrub resource span description even when we don't detect an extension #2591

merged 16 commits into from
Oct 12, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Oct 11, 2023 •
edited
Loading

  • Fix fallback case for resource span scrubbing when the regex doesn't work
  • Expand the patterns we look for to identify a MongoDB query
  • Remove scrubbing for CoreData transactions

@phacops phacops requested review from jjbayer and a team October 11, 2023 18:45
phacops and others added 3 commits October 12, 2023 09:05
@phacops @jjbayer
Return nothing instead of an empty string.
68fe4ed 
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
@phacops @jjbayer
Fix description when scrubbed
0d6a106 
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
@phacops
Fix tests
f344cf3
@phacops phacops enabled auto-merge (squash) October 12, 2023 15:41
@phacops phacops merged commit 3fe2b4c into master Oct 12, 2023
@phacops phacops deleted the pierre/spans-scrub-resource-description-even-with-no-extension branch October 12, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhars nikhars nikhars approved these changes

@jjbayer jjbayer jjbayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phacops @jjbayer @nikhars