Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): Remove mobile outliers #2649

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Oct 24, 2023

The following measurements are not sent by newer mobile SDKs if they exceed 180 seconds:

  • app_start_cold
  • app_start_warm
  • time_to_initial_display
  • time_to_full_display

The same goes for the corresponding span ops. To align the behavior for normal SDKs and to prevent the skew that these outliers cause in averages, drop them in normalization / suppress their span metrics.

ref: internal issue

@jjbayer jjbayer changed the title Fix/spans mobile outliers fix(spans): Remove mobile outliers Oct 24, 2023
@jjbayer jjbayer marked this pull request as ready for review October 24, 2023 09:40
@jjbayer jjbayer requested review from a team and shruthilayaj October 24, 2023 09:40
@jjbayer jjbayer requested a review from a team October 24, 2023 10:55
@jjbayer jjbayer enabled auto-merge (squash) October 24, 2023 10:55
@jjbayer jjbayer merged commit ceb1f09 into master Oct 24, 2023
@jjbayer jjbayer deleted the fix/spans-mobile-outliers branch October 24, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants