feat(spans): Group by domain and last segment of the path #2654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to group by the full path, since it's containing a whole lot of cardinality, we'll isolate the last part of the path (which is usually the filename of the resource but can also be a part of the path or empty if the URL finishes with a
/
), scrub this part only and construct a group based on the scrubbed domain and this scrubbed last part.@jjbayer I don't think the logic meaning to add a dummy base URL to relative or absolute paths is working as intended. In the case of domains without a scheme, the dummy domain is added and is now part of the path, which means it's scrapped with this PR. I haven't figured out a proper solution to this issue yet. Ideally, we'd identify the scheme is empty and use a dummy scheme or something.