feat(spans): Add TTID and TTFD tags #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Oct 27, 2023
Comment on lines
894
to
895
| assert_eq!(tags.get("ttid").unwrap().as_str(), Some("true")); | ||
| assert_eq!(tags.get("ttfd").unwrap().as_str(), Some("true")); |
There was a problem hiding this comment.
@shruthilayaj spans that contribute to initial display also contribute to full display. Does that make sense?
There was a problem hiding this comment.
yes, TTID contributing spans are a subset of TTFD contributing spans!
olksdr
approved these changes
Oct 27, 2023
| span_tags | ||
| } | ||
|
|
||
| /// Finds time-to-initial/full-display spans and returns its end times. | ||
| fn display_times(spans: &[Annotated<Span>]) -> (Option<Timestamp>, Option<Timestamp>) { |
There was a problem hiding this comment.
Maybe instead of the tuple here it would be clearer to create a struct and set the fields with proper names in it.
It can be easy to mistaken the order of the returned values just looking at the function signature.
There was a problem hiding this comment.
Good point. I refactored this to use .find() instead of writing a homemade loop now, let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
ui.load.initial_displayand/orui.load.full_displayspans are present, mark spans happening before those withttidandttfdtags.