fix(metrics): Bump generic extraction version #2692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External relays of version 23.9.1 (and possibly below) set the
metrics_extracted
flag on transaction items even if transaction metrics extraction is disabled:relay/relay-server/src/actors/processor.rs
Lines 2099 to 2104 in ffebe60
We recently bumped the transaction metrics version, causing external relays to skip extraction. But because old external relays set the
metrics_extracted
flag anyway, even our internal PoPs skip metrics extraction now.This PR is a one-time fix to force old external relays to stop extracting generic metrics as well.