Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): Bump generic extraction version #2692

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Nov 7, 2023

External relays of version 23.9.1 (and possibly below) set the metrics_extracted flag on transaction items even if transaction metrics extraction is disabled:

let metrics = crate::metrics_extraction::event::extract_metrics(event, config);
state.event_metrics_extracted |= !metrics.is_empty();
state.extracted_metrics.project_metrics.extend(metrics);
}
match state.project_state.config.transaction_metrics {

We recently bumped the transaction metrics version, causing external relays to skip extraction. But because old external relays set the metrics_extracted flag anyway, even our internal PoPs skip metrics extraction now.

This PR is a one-time fix to force old external relays to stop extracting generic metrics as well.

@jjbayer jjbayer marked this pull request as ready for review November 7, 2023 10:54
@jjbayer jjbayer requested a review from a team November 7, 2023 10:54
@jjbayer jjbayer merged commit 7f0e641 into master Nov 7, 2023
@jjbayer jjbayer deleted the fix/bump-metrics-extraction-version branch November 7, 2023 13:24
jjbayer added a commit to getsentry/sentry that referenced this pull request Nov 7, 2023
See getsentry/relay#2692.

Do not merge this PR before the relay PR has been deployed!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants