fix(pii): Removes legacy special behaviour from safe fields parsing #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
fix/safe-fields-legacy
branch
from
1fdcbe3 to
ef4ab5f
Compare
jjbayer
approved these changes
Nov 8, 2023
Comment on lines
+174
to
+177
| .unwrap() | ||
| .into_inner() | ||
| .next() | ||
| .unwrap(), |
There was a problem hiding this comment.
In a next step we should try to get rid of these unwraps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safe fields parsing accidentally triggered legacy behaviour which in some cases could disable data scrubbing for all strings