ref(normalization): Replace LightNormalization with NormalizeProcessor #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iker-barriocanal
changed the title
`LightNormalizationConfig` is no longer required by `NormalizeProcessor`.
Removes the function `light_normalize_event` and the required config `LightNormalizationConfig`.
This commit replaces direct calls to light normalization with invoking the normalize processor directly.
iker-barriocanal
force-pushed
the
iker/ref/rm-light-norm
branch
from
de701d2 to
7ffc1a4
Compare
TBS1996
approved these changes
Nov 17, 2023
olksdr
approved these changes
Nov 17, 2023
| &mut event, | ||
| &mut NormalizeProcessor::new(normalization_config), | ||
| ProcessingState::root(), | ||
| )?; |
There was a problem hiding this comment.
So we still use store processor here after the new NormalizeProcessor?
There was a problem hiding this comment.
Yes. We still need to run both processors in some circumstances until we unify them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes light normalization in favor of using
NormalizeProcessordirectly, and updates all the calls to directly invokeNormalizeProcessor. There are no functional changes in this PR, just refactors. Note this PR doesn't get rid of "light normalization" as a concept entirely, as it's referenced in other parts of the codebase. That will be addressed in future PRs.It's suggested to review commits sequentially.
#skip-changelog