fix(profiling): Transfer profile ID when the event has been extracted #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Nov 16, 2023
| @@ -2756,6 +2769,7 @@ impl EnvelopeProcessorService { | |||
| }); | |||
|
|
|||
| self.extract_event(state)?; | |||
| self.transfer_profile_id(state); | |||
There was a problem hiding this comment.
This is the main change of this PR: The transfer of the profile ID happens after event extraction. The rest of the PR is largely identical with #2715.
jjbayer
changed the title
olksdr
approved these changes
Nov 17, 2023
relay-server/src/actors/processor.rs
Outdated
Comment on lines
4454
to
4456
|
|
||
| #[tokio::test] | ||
| async fn test_profile_id_transfered() { |
There was a problem hiding this comment.
does this have to be tokio::test and async?
There was a problem hiding this comment.
👍 It can be sync if I use dummy Addrs instead of mock_service. Changed here: e68e1ba
iker-barriocanal
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay copies profile IDs into a transaction context in order to associate profiles to transactions.
In #2715, we tried to move this extraction to a point before dynamic sampling, so we can define transaction sampling rules based on the profile ID. However, the PR tried to do this at a point where the event had not been parsed yet, resulting in the profile ID always missing.
As @olksdr pointed out,