feat(webvitals): Updates performance score values to use 0-1 cdf values instead of the actual raw component score #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore-cdf-instead-of-score-for-performance-score-calculation
iker-barriocanal
approved these changes
Nov 21, 2023
| @@ -915,7 +916,7 @@ fn normalize_performance_score( | |||
| measurements.insert( | |||
| "score.total".to_owned(), | |||
| Measurement { | |||
| value: score_total.into(), | |||
| value: (score_total / weight_total).into(), | |||
There was a problem hiding this comment.
Not actionable for this PR, but to not forget about if/how we can remove the score.total measurement.
jjbayer
approved these changes
Nov 21, 2023
edwardgou-sentry
deleted the
egou/feat/store-cdf-instead-of-score-for-performance-score-calculation
branch
|
If you're planning on doing I wrote storing weights / weighted scores as a one liner on the original doc, but it was almost a footnote, it really deserves it's own section, I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates web vital performance score component values to use 0 - 1 cdf values instead of the actual raw component score. The raw component scores have dynamic upper bounds depending on the component weights provided, so we should use the cdf values since they're bound between 0 - 1 (which we can combine with the weight to get the actual score in the product).