feat(metric-meta): Add support for metric metadata #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
feat/metric-metadata
branch
2 times, most recently
from
b21cf98 to
605c257
Compare
Dav1dde
force-pushed
the
feat/metric-metadata
branch
3 times, most recently
from
a76c8f5 to
1db5de2
Compare
Dav1dde
force-pushed
the
feat/metric-metadata
branch
2 times, most recently
from
dafb35b to
258fdeb
Compare
Dav1dde
force-pushed
the
feat/metric-metadata
branch
3 times, most recently
from
59d2b60 to
5ef85c0
Compare
Dav1dde
force-pushed
the
feat/metric-metadata
branch
2 times, most recently
from
a48f878 to
91da0d1
Compare
Dav1dde
force-pushed
the
feat/metric-metadata
branch
from
91da0d1 to
64aefb3
Compare
jan-auer
approved these changes
Nov 24, 2023
Dav1dde
commented
Nov 24, 2023
Dav1dde
commented
Nov 24, 2023
Dav1dde
commented
Nov 24, 2023
Dav1dde
force-pushed
the
feat/metric-metadata
branch
from
faa64da to
3e35438
Compare
sthagen
pushed a commit
to sthagen/getsentry-sentry-python
that referenced
this pull request
Nov 24, 2023
DDM wants to show code locations with metrics. Locations are semi-static information: they change infrequently, so they don't need to be reported with every data point. Sentry expects locations to be reported at least once per day. With backdating of metrics, the timestamp used to report the location is the metric bucket's timestamp rounded down to the start of the day (UTC timezone). The metrics aggregator keeps a cache of previously reported locations. When a location is seen for the first time on a day, it is added to a list of pending locations. On the next flush cycle, all pending locations are sent to Sentry in the same envelope as the metric buckets. See: getsentry/relay#2751 Epic: getsentry/sentry#60260 --------- Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com> Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
metric_metaenvelope item and storage in Redis.Epic: getsentry/sentry#60260