fix(user-report): Accept user reports with trailing whitespaces #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
fix/native-user-report
branch
from
79bed5b to
18fa31c
Compare
Dav1dde
force-pushed
the
fix/native-user-report
branch
from
18fa31c to
d26589a
Compare
olksdr
approved these changes
Nov 30, 2023
|
Okay so this is weird, the native SDK does not even implement the functionality to send user feedback reports and we are seeing this from a version that is >1 year outdated. Maybe the customer made some modifications to their SDK. I want to investigate this first before we go ahead with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a customer with a forked version of the native SDK which is sending invalid user reports with a trailing
\n. Trim the payload before parsing it to allow user reports to go through.