ref(metrics): Change flush into a cross-project message #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
force-pushed
the
ref/global-flush
branch
from
952abf3 to
d4a9ac0
Compare
jan-auer
force-pushed
the
ref/global-flush
branch
from
d4a9ac0 to
2ad53e9
Compare
jan-auer
commented
Dec 22, 2023
| /// DSN, this submits metrics to the global endpoint with Relay authentication. | ||
| /// | ||
| /// This option does not have any effect on processing mode. | ||
| global_metrics: bool, |
There was a problem hiding this comment.
This option is still inactive. Originally, I was going to implement the functionality in the same PR. Let me know if you prefer if I move this to the next PR.
6 tasks
iker-barriocanal
approved these changes
Dec 22, 2023
Dav1dde
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics aggregator service now flushes the buckets of all projects
in a single
FlushBucketsmessage. Previously, this message was emittedseparately for every project.
This change allows the processor to batch buckets from multiple projects
into a single request. This change is not yet included in this PR and
will be added in a follow-up.
#skip-changelog