feat(server): Send metrics via the global endpoint #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jan-auer
commented
Dec 22, 2023
| tags: &self.tags, | ||
| } | ||
| .hash64() | ||
| let mut hasher = FnvHasher::default(); |
There was a problem hiding this comment.
BucketKeyRef is no longer required. The hash created here and the hash used for partitioning do not have to be the same, which is why we can hash differently.
| /// | ||
| /// The distribution of buckets should be even. | ||
| /// If it is not, this metric should expose it. | ||
| PartitionKeys, |
There was a problem hiding this comment.
As partitioning is now exclusively in the processor, this metric has moved here from relay-metrics. Its key is still the same.
| bucket: self.current.bucket + at, | ||
| }; | ||
| } | ||
| self.current = Index { |
There was a problem hiding this comment.
The check for whether the bucket can split has been moved into split_at. Invariants for splitting are still checked in the inner iterator.
jan-auer
force-pushed
the
feat/global-flush-impl
branch
from
c62bbe4 to
b11353e
Compare
jjbayer
approved these changes
Jan 2, 2024
| }) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
There's a lot of metrics-specific methods here now, maybe we should move them to a submodule (as standalone functions) in a follow-up PR.
jjbayer
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an option
http.global_metrics. When enabled and not inprocessing mode, Relay sends metrics to the global batch endpoint at
/api/0/relays/metrics/instead of envelopes. This endpoint allows forbatched submission of metrics from multiple projects, which should
reduce the overall number of requests.
Bug Fixes
This change contains additional bug fixes that were discoverd during
implementation:
emit_outcomesoutcomes flag to be set. This was invalid copy & paste from the
outcomes endpoint.
compressed body. However, Relay requires the signature on the
uncompressed body.
Details
Building the request occurs in the
EnvelopeProcessorin place ofbuilding envelopes in the following steps:
partition reaches the batch size limit, flush the partition eagerly.
Buckets at the border may be split.
apply HTTP encoding (compression).
SendMetricsRequestwith the payload and outcomemetadata directly to the upstream.
request does not have to be awaited.
In processing mode, Relay still produces to Kafka. The configuration
option does not have an effect in processing mode.
A note on stability: This endpoint and functionality is meant for
operation at scale within a distributed Sentry installation. At this
moment, it is not recommended to enable this option for external Relays.
Tasks
Possible Improvements
The changes in this PR allow for further optimization and changes. In
order to keep the scope of this PR to a necessary minimum, these have
not been included yet:
EnvelopeProcessor,avoiding the roundtrip through the
EnvelopeManager. This also avoidsa redundant call back to compress envelopes in the processor, should
HTTP encoding be enabled.
ExtractionMode. It can be accessed moreconveniently through a getter. Additionally, it resides on project
config where it should actually be included in global config.
Currently it is being passed around in excess.