feat(app-start): Add duration metric for top-level app start spans #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new MetricSpec and conditions for retrieving tags for a duration metric.
narsaynorath
commented
Jan 3, 2024
|
Should this have a |
Needed to use glob and added a test to the mobile extraction test
jjbayer
approved these changes
Jan 4, 2024
narsaynorath
deleted the
nar/feat/spans-collect-duration-on-app-start-spans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new MetricSpec and conditions for retrieving tags for a duration metric.
For nested app start spans we can use self-time, but at the top-level we need to expose duration and filter by op and description (e.g.
app.start.coldandCold Start)