Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replays): Add error and trace uuid validation #2931

Merged
merged 6 commits into from
Jan 11, 2024
Merged

feat(replays): Add error and trace uuid validation #2931

merged 6 commits into from
Jan 11, 2024

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Jan 10, 2024 •
edited
Loading

annotated_struct.field.meta().has_errors() does not work as expected. I had to access struct.field.0.

@cmanallen cmanallen requested a review from a team as a code owner January 10, 2024 21:45
iker-barriocanal
iker-barriocanal approved these changes Jan 11, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@cmanallen cmanallen merged commit 16fd6db into master Jan 11, 2024
20 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-add-uuid-validation branch January 11, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer left review comments

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmanallen @jjbayer @iker-barriocanal