feat(server): Denylist for metrics #2954
Conversation
relay-dynamic-config/src/metrics.rs
Outdated
|
|
||
| impl Metrics { | ||
| /// Filters metrics based on the metric name. | ||
| pub fn filter_metrics(&self, metrics: &mut Vec<Bucket>) { |
There was a problem hiding this comment.
Let's move this function into a logic module to keep the config types plain. For now, processor.rs would be the ideal place for this, until all metrics related processing functionality moves into a dedicated module.
This means you can also remove the dependency on relay_metrics from this crate.
There was a problem hiding this comment.
I just moved this logic into the apply_filter_metrics function in project.rs, how do you think about that?
relay-dynamic-config/src/metrics.rs
Outdated
| #[derive(Debug, Default, Clone, Serialize, Deserialize)] | ||
| #[serde(transparent)] | ||
| pub struct Metrics { | ||
| /// Patterns of names of metrics that we want to filter. |
There was a problem hiding this comment.
| /// Patterns of names of metrics that we want to filter. | |
| /// The list of patterns which used to filter names of the received metrics. |
Maybe something like this will sound better?
There was a problem hiding this comment.
hmm, isnt it a bit misleading, like we want to say we filter metrics based on their name, not that we filter their names?
how about /// List of patterns for blocking metrics based on their name. ?
Co-authored-by: Jan Michael Auer <mail@jauer.org>
relay-dynamic-config/src/metrics.rs
Outdated
| } | ||
|
|
||
| impl Metrics { | ||
| /// Returns `true` if it contains any names patterns to filter metric names. |
There was a problem hiding this comment.
This comment is outdated, is_empty does more now
relay-dynamic-config/src/project.rs
Outdated
| @@ -88,6 +89,9 @@ pub struct ProjectConfig { | |||
| /// relays that might still need them. | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub span_description_rules: Option<Vec<SpanDescriptionRule>>, | |||
| /// Configuration for filtering metrics. | |||
There was a problem hiding this comment.
| /// Configuration for filtering metrics. | |
| /// Configuration for metrics. |
New addition to projectconfig that allow users to filter out certain metrics based on their name using glob patterns.
#2796