fix(metrics-extraction): Add defaulting of required attributes in light normalization #2961
Conversation
| event.platform.get_or_insert_with(|| "other".to_string()); | ||
| event.level.get_or_insert_with(|| match event.ty.value() { |
There was a problem hiding this comment.
I have moved both platform and level normalization, since both defaulted to values which might be useful for metrics extraction. I could technically move all the default normalizations, @iker-barriocanal what do you think?
There was a problem hiding this comment.
This is good enough for now, thanks!
| @@ -1146,6 +1147,8 @@ mod tests { | |||
| ..Default::default() | |||
| }; | |||
|
|
|||
| assert_eq!(Some(Val::String("info")), event.get_value("event.level")); | |||
There was a problem hiding this comment.
Added this test just to make sure the getter works as expected.
| // Set required attributes to default values if not present. | ||
| normalize_default_required_attrs(event); |
There was a problem hiding this comment.
Let's move this lower, as the event may still be rejected after this point. There are some required attribute normalization on line 255, that could be a good place.
There was a problem hiding this comment.
Thanks for the tip! Will do
| event.platform.get_or_insert_with(|| "other".to_string()); | ||
| event.level.get_or_insert_with(|| match event.ty.value() { |
There was a problem hiding this comment.
This is good enough for now, thanks!
This PR adds a new normalization step in the light normalization pipeline which normalizes required attributes that have no value. The need for this change arises from metrics extraction, which is run after light normalization and requires the event payload to be normalized almost entirely to perform the correct conditional extraction.