fix(spans): Apply max. SQL expression depth after simplification #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
olksdr
approved these changes
Jan 26, 2024
relay-event-normalization/src/normalize/span/description/sql/parser.rs
Outdated
Show resolved
Hide resolved
gggritso
approved these changes
Jan 26, 2024
…arser.rs Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
iker-barriocanal
approved these changes
Jan 29, 2024
@gggritso Yes, we're losing that. Because this normalization is quite general, there might also be a bunch of other cases where we now remove parentheses, i.e. there will be grouping changes. If you feel strongly about I can revert this part, but it will result in duplicate groups for the case we're trying to fix. |
|
@jjbayer 🚢 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeating OR/AND conditions are collapsed, but if the maximum query depth is reached, the limit is applied before we can collapse it. This leads to scrubbed queries like:
Fix by splitting the query visitor into two steps (first normalize, then reduce depth).
This PR also removes redundant parentheses around binary operations (e.g.
a OR (b OR c)).ref: internal issue