Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore(spans): Upgrade sqlparser" #3059

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Revert "chore(spans): Upgrade sqlparser" #3059

merged 1 commit into from
Feb 6, 2024
+95 −127

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Feb 6, 2024 •
edited
Loading

Causes panics, see RELAY-2NRB.

Reverts #3057

#skip-changelog

@jjbayer jjbayer requested a review from a team as a code owner February 6, 2024 13:48
@jjbayer jjbayer enabled auto-merge (squash) February 6, 2024 13:58
@jjbayer jjbayer merged commit 5a19c7b into master Feb 6, 2024
20 of 21 checks passed
@jjbayer jjbayer deleted the revert-3057-chore/sqlparser-043 branch February 6, 2024 14:10
@jjbayer jjbayer mentioned this pull request Feb 6, 2024
Merged
jjbayer added a commit that referenced this pull request Feb 8, 2024
@jjbayer
fix(spans): Catch panic when parsing SQL (#3064)
c18b04e 
This PR reapplies #3057, which was
[reverted](#3059) because of
panics.

As a workaround, catch unwind panics so we can collect panic cases and
report them upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olksdr olksdr olksdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjbayer @olksdr