ref(replays): video item #3149
Merged
ref(replays): video item #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Feb 22, 2024
| config: &ProjectConfig, | ||
| client_ip: Option<IpAddr>, | ||
| user_agent: &RawUserAgentInfo<&str>, | ||
| ) -> ProcessingAction<String> { | ||
| match process_replay_event(payload, config, client_ip, user_agent) { | ||
| ) -> Result<Bytes, Outcome> { |
There was a problem hiding this comment.
@cmanallen I refactored ProcessingAction to Result<Bytes, Outcome>, let me know if you like it. By using Bytes, which is a lightweight, reference-counted object, we can fold the Keep and Replace cases into one.
Comment on lines
+880
to
+884
| struct VideoEvent<'a> { | ||
| replay_event: &'a [u8], | ||
| replay_recording: &'a [u8], | ||
| replay_video: &'a [u8], | ||
| } |
There was a problem hiding this comment.
Deserializing this is cheap, because it does not copy any data.
| } | ||
|
|
||
| ProcessingAction::Replace((replay_event, replay_recording, event.replay_video)) | ||
| match rmp_serde::to_vec_named(&ReplayVideoEvent { |
There was a problem hiding this comment.
It's unfortunate that we need to serialize here, but it's a known problem that we plan to fix for other item types as well.
If we do not serialize back into the envelope, the data will be lost in PoP Relays.
olksdr
approved these changes
Feb 22, 2024
Dav1dde
approved these changes
Feb 22, 2024
cmanallen
merged commit e6e193c
into
cmanallen/replays-add-video-envelope-item
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize processed replay video item back into the envelope instead of putting it on the header.
#skip-changelog