feat(server): Scrub transactions before enforcing quotas #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
jjbayer
commented
Mar 21, 2024
Comment on lines
+1161
to
+1162
| assert len(spans) == 0 # all rejected | ||
| assert summarize_outcomes() == {(16, 2): 2} # SpanIndexed, RateLimited |
There was a problem hiding this comment.
These assertions fail without the change in process_transactions.
Dav1dde
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously enforced quotas before PII scrubbing because rate limiting did not depend on having PII-scrubbed data.
Now that we want to rate limit spans that are extracted from transactions, which in turn depend on PII-scrubbing, we need to turn the order around.
Note that this should barely increase cost, because the vast majority of rate limited events is caught by cached rate limits on the fast path, not the consistent rate limiting step in the processor (which is mainly there for incrementing the redis counter).