feat(spans): Enable Redis span metrics ingestion #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
approved these changes
Mar 18, 2024
phacops
changed the title
phacops
changed the title
jjbayer
approved these changes
Mar 19, 2024
Dav1dde
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for getsentry/sentry#66875
Enables metrics for redis spans that will be used within the cache module. We will be adding any necessary tags in the future PRs once any SDK changes are in place.
This was previously disabled because we didn't use it, but now we are looking into redis for the caching module.
We're also wildcarding the key here, so this should be fairly low cardinality.