feat(spans): Collect duration for all spans #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Code looks good to me, but I think we should add a kill switch (automator option exposed through RELAY_OPTIONS). This change will again add a lot of metrics buckets, and we've already been hitting internal limits recently.
jjbayer
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
With https://github.com/getsentry/ops/pull/9815 in place soon, I think we can risk this. We can always roll back if the load is too high.
One integration test seems to need updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance summary page and trace explorer will require we collect this metric for all spans.
As for
exclusive_time, we'll limit cardinality by having a reduced number of tags.