feat(schema): Allow integers as username #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Mar 26, 2024
Comment on lines
+209
to
+215
| let user = Annotated::new(User { | ||
| username: Annotated::new("42".to_string().into()), | ||
| ..User::default() | ||
| }); | ||
|
|
||
| assert_eq!(user, Annotated::from_json(input).unwrap()); | ||
| assert_eq!(output, user.to_json().unwrap()); |
There was a problem hiding this comment.
imo the round trip is enough
assert_eq!( Annotated::from_json(input).unwrap().to_json().unwrap(), r#"{"username":"42"}"#)Can also maybe just use insta here to assert the output?
There was a problem hiding this comment.
I copy-pasted the existing tests around this, would like to keep them as similar as possible.
olksdr
approved these changes
Mar 26, 2024
iker-barriocanal
approved these changes
Mar 27, 2024
| @@ -9,6 +9,7 @@ | |||
| - Extract op and description while converting opentelemetry spans to sentry spans. ([#3287](https://github.com/getsentry/relay/pull/3287)) | |||
| - Drop `event_id` and `remote_addr` from all outcomes. ([#3319](https://github.com/getsentry/relay/pull/3319)) | |||
| - Support for AI token metrics ([#3250](https://github.com/getsentry/relay/pull/3250)) | |||
| - Accept integers in `event.user.username`. ([#3328](https://github.com/getsentry/relay/pull/3328)) | |||
There was a problem hiding this comment.
nit: floats are also accepted in LenientString
Suggested change
| - Accept integers in `event.user.username`. ([#3328](https://github.com/getsentry/relay/pull/3328)) | |
| - Accept numbers in `event.user.username`. ([#3328](https://github.com/getsentry/relay/pull/3328)) |
jan-auer
added a commit
that referenced
this pull request
Mar 28, 2024
* master: ref(cardinality): Pipeline Redis script invocations (#3321) ref(normalization): Remove StoreProcessor (#3097) feat(cardinality): Implement name based cardinality limits (#3313) instr(kafka): Tag existing metrics with variant (#3352) instr(kafka): More broker stats (#3349) instr(kafka): Improve produce error handling (#3351) feat(schema): Allow integers as username (#3328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The django integration sends integers as usernames if the underlying
Usermodel returns an integer forget_username()(see issue).Fixes getsentry/sentry#67601.