feat(spans): extract cache size and cache hit in indexed spans #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Apr 3, 2024
iker-barriocanal
approved these changes
Apr 3, 2024
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Joris Bayer <joris.bayer@sentry.io> Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
…t-cache-span-tags
…sentry/relay into DominikB2014/extract-cache-span-tags
DominikB2014
commented
Apr 3, 2024
| @@ -231,10 +231,18 @@ pub struct SpanData { | |||
| #[metastructure(field = "resource.render_blocking_status")] | |||
| pub resource_render_blocking_status: Annotated<Value>, | |||
|
|
|||
| /// Name of the database host. | |||
| /// Name of the web server host. | |||
There was a problem hiding this comment.
This was just an incorrect comment, I updated to reflect the value better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for getsentry/sentry#68118
This PR adds
cache.hittag for indexed cached spans (I believe we only support string values here, so i converted to string, please lmk otherwise!)cache.item_sizemeasurement for indexed cached spans#skip-changelog