feat(ai): Extract AI-related metrics from span data #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
requested changes
Apr 11, 2024
colin-sentry
changed the title
phacops
approved these changes
Apr 11, 2024
Zylphrex
reviewed
Apr 11, 2024
Dav1dde
reviewed
Apr 12, 2024
jjbayer
reviewed
Apr 12, 2024
colin-sentry
force-pushed
the
ai_metrics
branch
from
224c80a to
b3c5401
Compare
colin-sentry
force-pushed
the
ai_metrics
branch
7 times, most recently
from
d5a9297 to
6a73ddd
Compare
Dav1dde
approved these changes
Apr 16, 2024
| @@ -39,6 +39,7 @@ | |||
| - Scrub transactions before enforcing quotas. ([#3248](https://github.com/getsentry/relay/pull/3248)) | |||
| - Implement metric name based cardinality limits. ([#3313](https://github.com/getsentry/relay/pull/3313)) | |||
| - Kafka topic config supports default topic names as keys. ([#3282](https://github.com/getsentry/relay/pull/3282), [#3350](https://github.com/getsentry/relay/pull/3350)) | |||
| - Extract AI metrics from spans. ([#3412](https://github.com/getsentry/relay/pull/3412)) | |||
There was a problem hiding this comment.
Needs to be fixed, after the 24.4.0 release
iker-barriocanal
approved these changes
Apr 16, 2024
Comment on lines
+141
to
+143
| // `exclusive_time_light` excludes transaction tags (and some others) to reduce cardinality. | ||
| let exclusive_time_light_condition = (is_db.clone() | ||
| | is_ai.clone() |
There was a problem hiding this comment.
Are we still interested in extracting this metric for AI spans?
There was a problem hiding this comment.
+1, could we document the answer to this question here, even if it was discussed offline? Would be interesting to know.
There was a problem hiding this comment.
The intention is to build a view similar to the index page of the various performance modules like database where it surfaces these ai metrics across the project.
colin-sentry
force-pushed
the
ai_metrics
branch
from
6a73ddd to
9b13b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for ai.total_tokens.used metrics to be pulled from submitted spans