ref(kafka): Remove ShardedProducer #3415
Conversation
relay-kafka/src/producer/mod.rs
Outdated
| /// Sends the payload to the correct producer for the current topic. | ||
| fn send( | ||
| &self, | ||
| organization_id: u64, | ||
| _organization_id: u64, |
There was a problem hiding this comment.
This parameter is not needed anymore but it's piped through so much code that I was wondering if we should keep it for future use. If not, we can remove it.
CHANGELOG.md
Outdated
| @@ -44,6 +44,7 @@ | |||
| - Route spans according to trace_id. ([#3387](https://github.com/getsentry/relay/pull/3387)) | |||
| - Log span when encountering a validation error. ([#3401](https://github.com/getsentry/relay/pull/3401)) | |||
| - Optionally skip normalization. ([#3377](https://github.com/getsentry/relay/pull/3377)) | |||
| - Remove `ShardedProducer`. ([#3415](https://github.com/getsentry/relay/pull/3415)) | |||
There was a problem hiding this comment.
Can we mark this as a breaking change and put it under the other breaking change in **Features**?
There was a problem hiding this comment.
@iambriccardo can you also mark it as a breaking change?
There was a problem hiding this comment.
How do we mark it as a breaking change?
There was a problem hiding this comment.
And now move it below the other breaking change :p.
Yeah it's not very fancy, we should probably at some point rework our changelog a bit.
There was a problem hiding this comment.
I feel like we should just create a set of rules that one should follow since right now it's a bit copy pasty.
relay-kafka/src/producer/mod.rs
Outdated
| /// Sends the payload to the correct producer for the current topic. | ||
| fn send( | ||
| &self, | ||
| organization_id: u64, | ||
| _organization_id: u64, |
|
I made sure that no active configs in prod are using the sharded configuration. |
Remove `SingleProducer` and `ProducerInner` types. Follow-up to #3415. --------- Co-authored-by: David Herberth <david.herberth@sentry.io>
This PR removes the
ShardedProducerand it's related configuration params since it's not used anymore.Closes: #3339