feat(spans): Forward span.data on the Kafka message #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
May 3, 2024
| @@ -1390,6 +1390,8 @@ struct SpanKafkaMessage<'a> { | |||
| #[serde(default)] | |||
| is_segment: bool, | |||
|
|
|||
| #[serde(default, skip_serializing_if = "none_or_empty_object")] | |||
| data: Option<&'a RawValue>, | |||
There was a problem hiding this comment.
I was confused where this field is set, then saw that it's because of the useless serialization roundtrip 🤣
There was a problem hiding this comment.
Yeah we're basically trying to make the roundtrip as cheap as possible.
jjbayer
approved these changes
May 3, 2024
| @@ -1390,6 +1390,8 @@ struct SpanKafkaMessage<'a> { | |||
| #[serde(default)] | |||
| is_segment: bool, | |||
|
|
|||
| #[serde(default, skip_serializing_if = "none_or_empty_object")] | |||
| data: Option<&'a RawValue>, | |||
There was a problem hiding this comment.
Yeah we're basically trying to make the roundtrip as cheap as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to use more data from the span and eventually store it. First step is to add it to the span Kafka message so downstream can use it.
We understand there might be some duplication between
sentry_tagsanddataand we accept it for now to not have to parse the object.